diff options
| author | Bongsu Jeon <bongsu.jeon@samsung.com> | 2020-12-31 03:59:26 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-01-06 01:06:34 +0100 |
| commit | f011539e723c737b74876ac47345e40270a3c384 (patch) | |
| tree | 095d62371421093dbe2257e8fbee2f519c326f3a /net/nfc | |
| parent | net: kcm: Replace fput with sockfd_put (diff) | |
| download | linux-f011539e723c737b74876ac47345e40270a3c384.tar.xz linux-f011539e723c737b74876ac47345e40270a3c384.zip | |
net: nfc: nci: Change the NCI close sequence
If there is a NCI command in work queue after closing the NCI device at
nci_unregister_device, The NCI command timer starts at flush_workqueue
function and then NCI command timeout handler would be called 5 second
after flushing the NCI command work queue and destroying the queue.
At that time, the timeout handler would try to use NCI command work queue
that is destroyed already. it will causes the problem. To avoid this
abnormal situation, change the sequence to prevent the NCI command timeout
handler from being called after destroying the NCI command work queue.
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/nfc')
| -rw-r--r-- | net/nfc/nci/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index e64727e1a72f..79bebf4b0796 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -579,11 +579,11 @@ static int nci_close_device(struct nci_dev *ndev) clear_bit(NCI_INIT, &ndev->flags); - del_timer_sync(&ndev->cmd_timer); - /* Flush cmd wq */ flush_workqueue(ndev->cmd_wq); + del_timer_sync(&ndev->cmd_timer); + /* Clear flags */ ndev->flags = 0; |