diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2019-03-15 05:20:16 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-03-16 19:35:58 +0100 |
| commit | 6f19893b644a9454d85e593b5e90914e7a72b7dd (patch) | |
| tree | 5a929c79029a9bc1158827051b8756bbcd0c7f5c /net/openvswitch/datapath.c | |
| parent | tun: properly test for IFF_UP (diff) | |
| download | linux-6f19893b644a9454d85e593b5e90914e7a72b7dd.tar.xz linux-6f19893b644a9454d85e593b5e90914e7a72b7dd.zip | |
net: openvswitch: fix a NULL pointer dereference
upcall is dereferenced even when genlmsg_put fails. The fix
goto out to avoid the NULL pointer dereference in this case.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/openvswitch/datapath.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 6679e96ab1dc..45d1469308b0 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -448,6 +448,10 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, upcall = genlmsg_put(user_skb, 0, 0, &dp_packet_genl_family, 0, upcall_info->cmd); + if (!upcall) { + err = -EINVAL; + goto out; + } upcall->dp_ifindex = dp_ifindex; err = ovs_nla_put_key(key, key, OVS_PACKET_ATTR_KEY, false, user_skb); |