diff options
| author | Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-11-25 20:14:40 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-11-26 18:15:33 +0100 |
| commit | 2734166e89639c973c6e125ac8bcfc2d9db72b70 (patch) | |
| tree | 8a45c79aa484e895deb2e413981f08c7b277178a /net/openvswitch | |
| parent | uapi: add SPDX identifier to vm_sockets_diag.h (diff) | |
| download | linux-2734166e89639c973c6e125ac8bcfc2d9db72b70.tar.xz linux-2734166e89639c973c6e125ac8bcfc2d9db72b70.zip | |
net: openvswitch: datapath: fix data type in queue_gso_packets
gso_type is being used in binary AND operations together with SKB_GSO_UDP.
The issue is that variable gso_type is of type unsigned short and
SKB_GSO_UDP expands to more than 16 bits:
SKB_GSO_UDP = 1 << 16
this makes any binary AND operation between gso_type and SKB_GSO_UDP to
be always zero, hence making some code unreachable and likely causing
undesired behavior.
Fix this by changing the data type of variable gso_type to unsigned int.
Addresses-Coverity-ID: 1462223
Fixes: 0c19f846d582 ("net: accept UFO datagrams from tuntap and packet")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/openvswitch')
| -rw-r--r-- | net/openvswitch/datapath.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 99cfafc2a139..ef38e5aecd28 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -308,7 +308,7 @@ static int queue_gso_packets(struct datapath *dp, struct sk_buff *skb, const struct dp_upcall_info *upcall_info, uint32_t cutlen) { - unsigned short gso_type = skb_shinfo(skb)->gso_type; + unsigned int gso_type = skb_shinfo(skb)->gso_type; struct sw_flow_key later_key; struct sk_buff *segs, *nskb; int err; |