diff options
| author | Hangyu Hua <hbh25y@gmail.com> | 2021-12-09 09:28:39 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-12-11 04:53:52 +0100 |
| commit | bcd0f93353326954817a4f9fa55ec57fb38acbb0 (patch) | |
| tree | 0cfe057392b7fe2cd2ebff355654487bec6c7573 /net/phonet | |
| parent | sch_cake: do not call cake_destroy() from cake_init() (diff) | |
| download | linux-bcd0f93353326954817a4f9fa55ec57fb38acbb0.tar.xz linux-bcd0f93353326954817a4f9fa55ec57fb38acbb0.zip | |
phonet: refcount leak in pep_sock_accep
sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/phonet')
| -rw-r--r-- | net/phonet/pep.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/phonet/pep.c b/net/phonet/pep.c index a1525916885a..b4f90afb0638 100644 --- a/net/phonet/pep.c +++ b/net/phonet/pep.c @@ -868,6 +868,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp, err = pep_accept_conn(newsk, skb); if (err) { + __sock_put(sk); sock_put(newsk); newsk = NULL; goto drop; |