diff options
| author | Andy Grover <andy.grover@oracle.com> | 2010-03-11 14:49:55 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-17 05:16:53 +0100 |
| commit | 735f61e62611161588123930823af6e6a9fd5c2c (patch) | |
| tree | d07e16026909daa692ddab9c7b0801cc418cb3bc /net/rds/ib_send.c | |
| parent | bridge: Make first arg to deliver_clone const. (diff) | |
| download | linux-735f61e62611161588123930823af6e6a9fd5c2c.tar.xz linux-735f61e62611161588123930823af6e6a9fd5c2c.zip | |
RDS: Do not BUG() on error returned from ib_post_send
BUGging on a runtime error code should be avoided. This
patch also eliminates all other BUG()s that have no real
reason to exist.
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds/ib_send.c')
| -rw-r--r-- | net/rds/ib_send.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c index a10fab6886d1..f380c3f01256 100644 --- a/net/rds/ib_send.c +++ b/net/rds/ib_send.c @@ -574,8 +574,7 @@ int rds_ib_xmit(struct rds_connection *conn, struct rds_message *rm, rds_ib_send_grab_credits(ic, 0, &posted, 1, RDS_MAX_ADV_CREDIT - adv_credits); adv_credits += posted; BUG_ON(adv_credits > 255); - } else if (ic->i_rm != rm) - BUG(); + } send = &ic->i_sends[pos]; first = send; @@ -714,8 +713,8 @@ add_header: ic->i_rm = prev->s_rm; prev->s_rm = NULL; } - /* Finesse this later */ - BUG(); + + rds_ib_conn_error(ic->conn, "ib_post_send failed\n"); goto out; } |