diff options
author | Daniel Borkmann <dborkman@redhat.com> | 2015-01-22 10:41:02 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-01-27 00:50:19 +0100 |
commit | 3f2ab135946dcd4eb6af92a53d6d4bd35e7526ca (patch) | |
tree | 8d640016c0d8f2edd82147c2c24694f0f0ea3bd0 /net/rfkill | |
parent | net: cls_bpf: fix size mismatch on filter preparation (diff) | |
download | linux-3f2ab135946dcd4eb6af92a53d6d4bd35e7526ca.tar.xz linux-3f2ab135946dcd4eb6af92a53d6d4bd35e7526ca.zip |
net: cls_bpf: fix auto generation of per list handles
When creating a bpf classifier in tc with priority collisions and
invoking automatic unique handle assignment, cls_bpf_grab_new_handle()
will return a wrong handle id which in fact is non-unique. Usually
altering of specific filters is being addressed over major id, but
in case of collisions we result in a filter chain, where handle ids
address individual cls_bpf_progs inside the classifier.
Issue is, in cls_bpf_grab_new_handle() we probe for head->hgen handle
in cls_bpf_get() and in case we found a free handle, we're supposed
to use exactly head->hgen. In case of insufficient numbers of handles,
we bail out later as handle id 0 is not allowed.
Fixes: 7d1d65cb84e1 ("net: sched: cls_bpf: add BPF-based classifier")
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rfkill')
0 files changed, 0 insertions, 0 deletions