diff options
| author | Ben Hutchings <ben@decadent.org.uk> | 2009-12-14 17:05:09 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-01-04 06:18:40 +0100 |
| commit | 35bb5cadc8c7b1462df57e32e08d964f1be7a75c (patch) | |
| tree | bc8c8182bfba02caaf3f571e22dfc5581f2d0aa8 /net/rose/rose_loopback.c | |
| parent | fsl_pq_mdio: Fix iomem unmapping for non-eTSEC2.0 controllers (diff) | |
| download | linux-35bb5cadc8c7b1462df57e32e08d964f1be7a75c.tar.xz linux-35bb5cadc8c7b1462df57e32e08d964f1be7a75c.zip | |
via-velocity: Give RX descriptors to the NIC later on open or MTU change
velocity_open() calls velocity_give_many_rx_descs(), which gives RX
descriptors to the NIC, before installing an interrupt handler or
calling velocity_init_registers(). I think this is very unsafe and it
appears to explain the bug report <http://bugs.debian.org/508527>.
On MTU change, velocity_give_many_rx_descs() is again called before
velocity_init_registers(). I'm not sure whether this is unsafe but
it does look wrong.
Therefore, move the calls to velocity_give_many_rx_descs() after
request_irq() and velocity_init_registers().
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Tested-by: Jan Ceuleers <jan.ceuleers@computer.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose/rose_loopback.c')
0 files changed, 0 insertions, 0 deletions