diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2013-10-11 19:51:38 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2013-10-16 09:59:53 +0200 |
| commit | ed05e204af5a2a7814858407bfd698d51e31f938 (patch) | |
| tree | f13c8d098a36c5e375f75c5c77afe55e2f723227 /net/rose | |
| parent | gpio: rcar: drop references to "virtual" IRQ (diff) | |
| download | linux-ed05e204af5a2a7814858407bfd698d51e31f938.tar.xz linux-ed05e204af5a2a7814858407bfd698d51e31f938.zip | |
gpio: stmpe: drop references to "virtual" IRQ, fix bug
Rename the argument "virq" to just "irq", this IRQ isn't any
more "virtual" than any other Linux IRQ number, we use "hwirq"
for the actual hw-numbers, "virq" is just bogus.
When doing this I see that the hwirq argument is used
for mapping rather than the Linux IRQ in the map function.
This doesn't look right. Use the Linux IRQ instead.
I cannot test this patch so I don't know if the mapping change
is correct, however since absolutely every other driver does
it the other way around this doesn't look sound at all. Please
help out with review.
Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Gabriel Fernandez <gabriel.fernandez@st.com>
Cc: Jean-Nicolas Graux <jean-nicolas.graux@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'net/rose')
0 files changed, 0 insertions, 0 deletions