diff options
| author | David Howells <dhowells@redhat.com> | 2020-09-14 16:58:14 +0200 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-09-14 17:18:59 +0200 |
| commit | f1b449748760e333a6aeef2455f3875be07c9b5a (patch) | |
| tree | 8305b654a4a88150abace664b19125dce465b1f1 /net/rxrpc/conn_client.c | |
| parent | rxrpc: Fix conn bundle leak in net-namespace exit (diff) | |
| download | linux-f1b449748760e333a6aeef2455f3875be07c9b5a.tar.xz linux-f1b449748760e333a6aeef2455f3875be07c9b5a.zip | |
rxrpc: Fix an overget of the conn bundle when setting up a client conn
When setting up a client connection, a second ref is accidentally obtained
on the connection bundle (we get one when allocating the conn and a second
one when adding the conn to the bundle).
Fix it to only use the ref obtained by rxrpc_alloc_client_connection() and
not to add a second when adding the candidate conn to the bundle.
Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/conn_client.c')
| -rw-r--r-- | net/rxrpc/conn_client.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c index 0eb36ba52485..78c845a4f1ad 100644 --- a/net/rxrpc/conn_client.c +++ b/net/rxrpc/conn_client.c @@ -433,7 +433,6 @@ static void rxrpc_add_conn_to_bundle(struct rxrpc_bundle *bundle, gfp_t gfp) if (!rxrpc_may_reuse_conn(old)) { if (old) trace_rxrpc_client(old, -1, rxrpc_client_replace); - candidate->bundle = rxrpc_get_bundle(bundle); candidate->bundle_shift = shift; bundle->conns[i] = candidate; for (j = 0; j < RXRPC_MAXCALLS; j++) |