diff options
| author | David Howells <dhowells@redhat.com> | 2018-09-27 16:13:09 +0200 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2018-09-28 11:33:17 +0200 |
| commit | f334430316e7fd37c4821ebec627e27714bb5d76 (patch) | |
| tree | a8e7fb558d409f5a36ba8104975272ed91b5ab9a /net/rxrpc/conn_object.c | |
| parent | rxrpc: Fix transport sockopts to get IPv4 errors on an IPv6 socket (diff) | |
| download | linux-f334430316e7fd37c4821ebec627e27714bb5d76.tar.xz linux-f334430316e7fd37c4821ebec627e27714bb5d76.zip | |
rxrpc: Fix error distribution
Fix error distribution by immediately delivering the errors to all the
affected calls rather than deferring them to a worker thread. The problem
with the latter is that retries and things can happen in the meantime when we
want to stop that sooner.
To this end:
(1) Stop the error distributor from removing calls from the error_targets
list so that peer->lock isn't needed to synchronise against other adds
and removals.
(2) Require the peer's error_targets list to be accessed with RCU, thereby
avoiding the need to take peer->lock over distribution.
(3) Don't attempt to affect a call's state if it is already marked complete.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/conn_object.c')
| -rw-r--r-- | net/rxrpc/conn_object.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/conn_object.c b/net/rxrpc/conn_object.c index b4438f98dc5c..885dae829f4a 100644 --- a/net/rxrpc/conn_object.c +++ b/net/rxrpc/conn_object.c @@ -216,7 +216,7 @@ void rxrpc_disconnect_call(struct rxrpc_call *call) call->peer->cong_cwnd = call->cong_cwnd; spin_lock_bh(&conn->params.peer->lock); - hlist_del_init(&call->error_link); + hlist_del_rcu(&call->error_link); spin_unlock_bh(&conn->params.peer->lock); if (rxrpc_is_client_call(call)) |