diff options
| author | Al Viro <viro@ftp.linux.org.uk> | 2007-07-26 18:33:29 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-26 20:11:56 +0200 |
| commit | 704eae1f32274c0435f7f3924077afdb811edd1d (patch) | |
| tree | 211d333d6f50ea078b6f4f29f0734eadcecdc37b /net/rxrpc | |
| parent | netfilter endian regressions (diff) | |
| download | linux-704eae1f32274c0435f7f3924077afdb811edd1d.tar.xz linux-704eae1f32274c0435f7f3924077afdb811edd1d.zip | |
ip6_tunnel - endianness annotations
Convert rel_info to host-endian before calling ip6_tnl_err().
The things become much more straightforward that way.
The key observation (and the reason why that code actually
worked) is that after ip6_tnl_err() we either immediately
bailed out or had rel_info set to 0 or had it set to host-endian
and guaranteed to hit
(rel_type == ICMP_DEST_UNREACH && rel_code == ICMP_FRAG_NEEDED)
case. So inconsistent endianness didn't really lead to bugs,
but it had been subtle and prone to breakage. New variant is
saner and obviously safe.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/rxrpc')
0 files changed, 0 insertions, 0 deletions