summaryrefslogtreecommitdiffstats
path: root/net/rxrpc
diff options
context:
space:
mode:
authorJon Maloy <jon.maloy@ericsson.com>2018-10-11 22:02:29 +0200
committerDavid S. Miller <davem@davemloft.net>2018-10-16 07:03:34 +0200
commit4af00f4cc1ba34da4654ac31830843cae871642d (patch)
treeba81a3cb69ca6ac7fe4af9eb537091862d8da4b6 /net/rxrpc
parentllc: set SOCK_RCU_FREE in llc_sap_add_socket() (diff)
downloadlinux-4af00f4cc1ba34da4654ac31830843cae871642d.tar.xz
linux-4af00f4cc1ba34da4654ac31830843cae871642d.zip
tipc: initialize broadcast link stale counter correctly
In the commit referred to below we added link tolerance as an additional criteria for declaring broadcast transmission "stale" and resetting the unicast links to the affected node. Unfortunately, this 'improvement' introduced two bugs, which each and one alone cause only limited problems, but combined lead to seemingly stochastic unicast link resets, depending on the amount of broadcast traffic transmitted. The first issue, a missing initialization of the 'tolerance' field of the receiver broadcast link, was recently fixed by commit 047491ea334a ("tipc: set link tolerance correctly in broadcast link"). Ths second issue, where we omit to reset the 'stale_cnt' field of the same link after a 'stale' period is over, leads to this counter accumulating over time, and in the absence of the 'tolerance' criteria leads to the above described symptoms. This commit adds the missing initialization. Fixes: a4dc70d46cf1 ("tipc: extend link reset criteria for stale packet retransmission") Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Acked-by: Ying Xue <ying.xue@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rxrpc')
0 files changed, 0 insertions, 0 deletions