diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2019-07-23 06:43:00 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-07-25 20:21:39 +0200 |
| commit | c8ec4632c6ac9cda0e8c3d51aa41eeab66585bd5 (patch) | |
| tree | c74a1286f66589e6e7b5fe0c82982b91cdf47bc8 /net/sched/act_ife.c | |
| parent | netrom: hold sock when setting skb->destructor (diff) | |
| download | linux-c8ec4632c6ac9cda0e8c3d51aa41eeab66585bd5.tar.xz linux-c8ec4632c6ac9cda0e8c3d51aa41eeab66585bd5.zip | |
ife: error out when nla attributes are empty
act_ife at least requires TCA_IFE_PARMS, so we have to bail out
when there is no attribute passed in.
Reported-by: syzbot+fbb5b288c9cb6a2eeac4@syzkaller.appspotmail.com
Fixes: ef6980b6becb ("introduce IFE action")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_ife.c')
| -rw-r--r-- | net/sched/act_ife.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 41d5398dd2f2..3578196d1600 100644 --- a/net/sched/act_ife.c +++ b/net/sched/act_ife.c @@ -481,6 +481,11 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla, int ret = 0; int err; + if (!nla) { + NL_SET_ERR_MSG_MOD(extack, "IFE requires attributes to be passed"); + return -EINVAL; + } + err = nla_parse_nested_deprecated(tb, TCA_IFE_MAX, nla, ife_policy, NULL); if (err < 0) |