diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-11-19 09:03:09 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-11-20 13:14:28 +0100 |
| commit | 47a1a1d4be2910b13a8e90f75c17e253c39531ff (patch) | |
| tree | c900f283bd96f0b26236152ada24f9a113f65e2b /net/sched/cls_cgroup.c | |
| parent | pkt_sched: remove unnecessary xchg() in packet schedulers (diff) | |
| download | linux-47a1a1d4be2910b13a8e90f75c17e253c39531ff.tar.xz linux-47a1a1d4be2910b13a8e90f75c17e253c39531ff.zip | |
pkt_sched: remove unnecessary xchg() in packet classifiers
The use of xchg() hasn't been necessary since 2.2.something when proper
locking was added to packet schedulers. In the case of classifiers they
mostly weren't even necessary before that since they're mainly used
to assign a NULL pointer to the filter root in the ->destroy path;
the root is destroyed immediately after that.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_cgroup.c')
| -rw-r--r-- | net/sched/cls_cgroup.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c index 53ada2c0e41c..0d68b1975983 100644 --- a/net/sched/cls_cgroup.c +++ b/net/sched/cls_cgroup.c @@ -201,9 +201,7 @@ static int cls_cgroup_change(struct tcf_proto *tp, unsigned long base, static void cls_cgroup_destroy(struct tcf_proto *tp) { - struct cls_cgroup_head *head; - - head = (struct cls_cgroup_head *)xchg(&tp->root, NULL); + struct cls_cgroup_head *head = tp->root; if (head) { tcf_exts_destroy(tp, &head->exts); |