diff options
| author | John Fastabend <john.fastabend@gmail.com> | 2014-09-17 20:11:46 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-09-19 23:05:45 +0200 |
| commit | 4e2840eee6b21cb5230bd7cac8407badb201aac3 (patch) | |
| tree | 9ff835e7c6d75beb754d1992b2bb24b7a6359567 /net/sched/cls_u32.c | |
| parent | net: sched: use __skb_queue_head_init() where applicable (diff) | |
| download | linux-4e2840eee6b21cb5230bd7cac8407badb201aac3.tar.xz linux-4e2840eee6b21cb5230bd7cac8407badb201aac3.zip | |
net: sched: cls_u32: rcu can not be last node
tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
structure and pads the structure with tc_u32_key fields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
CC: Eric Dumazet <edumazet@google.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_u32.c')
| -rw-r--r-- | net/sched/cls_u32.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index eceeb0456d26..730edb29d43b 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -64,8 +64,11 @@ struct tc_u_knode { u32 __percpu *pcpu_success; #endif struct tcf_proto *tp; - struct tc_u32_sel sel; struct rcu_head rcu; + /* The 'sel' field MUST be the last field in structure to allow for + * tc_u32_keys allocated at end of structure. + */ + struct tc_u32_sel sel; }; struct tc_u_hnode { |