summaryrefslogtreecommitdiffstats
path: root/net/sched/em_cmp.c
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2006-11-30 02:35:48 +0100
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-03 06:31:42 +0100
commit43effa1e57fc4635e0301b27d78f9d83afe78974 (patch)
treedc4a22fdaad074a547438050fb428f32b1cb2ded /net/sched/em_cmp.c
parent[NET_SCHED]: Set parent classid in default qdiscs (diff)
downloadlinux-43effa1e57fc4635e0301b27d78f9d83afe78974.tar.xz
linux-43effa1e57fc4635e0301b27d78f9d83afe78974.zip
[NET_SCHED]: Fix endless loops caused by inaccurate qlen counters (part 1)
There are multiple problems related to qlen adjustment that can lead to an upper qdisc getting out of sync with the real number of packets queued, leading to endless dequeueing attempts by the upper layer code. All qdiscs must maintain an accurate q.qlen counter. There are basically two groups of operations affecting the qlen: operations that propagate down the tree (enqueue, dequeue, requeue, drop, reset) beginning at the root qdisc and operations only affecting a subtree or single qdisc (change, graft, delete class). Since qlen changes during operations from the second group don't propagate to ancestor qdiscs, their qlen values become desynchronized. This patch adds a function to propagate qlen changes up the qdisc tree, optionally calling a callback function to perform qdisc-internal maintenance when the child qdisc becomes empty. The follow-up patches will convert all qdiscs to use this function where necessary. Noticed by Timo Steinbach <tsteinbach@astaro.com>. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/em_cmp.c')
0 files changed, 0 insertions, 0 deletions