diff options
| author | Bjørn Mork <bjorn@mork.no> | 2012-09-03 00:26:18 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-09-03 19:49:00 +0200 |
| commit | 85e87870fa18ec9f5df98e2d3b48f3699560a570 (patch) | |
| tree | 4130f26405eb5cd803b5f553faf8b4c8cb5a8548 /net/sched/sch_fq_codel.c | |
| parent | sctp: Don't charge for data in sndbuf again when transmitting packet (diff) | |
| download | linux-85e87870fa18ec9f5df98e2d3b48f3699560a570.tar.xz linux-85e87870fa18ec9f5df98e2d3b48f3699560a570.zip | |
net: usbnet: fix softirq storm on suspend
Suspending an open usbnet device results in constant
rescheduling of usbnet_bh.
commit 65841fd5 "usbnet: handle remote wakeup asap"
refactored the usbnet_bh code to allow sharing the
urb allocate and submit code with usbnet_resume. In
this process, a test for, and immediate return on,
ENOLINK from rx_submit was unintentionally dropped.
The rx queue will not grow if rx_submit fails,
making usbnet_bh reschedule itself. This results
in a softirq storm if the error is persistent.
rx_submit translates the usb_submit_urb error
EHOSTUNREACH into ENOLINK, so this is an expected
and persistent error for a suspended device. The
old code tested for this condition and avoided
rescheduling. Putting this test back.
Cc: <stable@vger.kernel.org> # v3.5
Cc: Ming Lei <ming.lei@canonical.com>
Cc: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_fq_codel.c')
0 files changed, 0 insertions, 0 deletions