diff options
| author | Jarek Poplawski <jarkao2@gmail.com> | 2008-08-27 11:25:17 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-08-27 11:25:17 +0200 |
| commit | f6f9b93f1624206c802ac9162c9302edaf59bfd9 (patch) | |
| tree | 643bd211bf909118311138e588a78834fad7a40d /net/sched/sch_hfsc.c | |
| parent | pkt_sched: Use rcu_assign_pointer() to change dev_queue->qdisc (diff) | |
| download | linux-f6f9b93f1624206c802ac9162c9302edaf59bfd9.tar.xz linux-f6f9b93f1624206c802ac9162c9302edaf59bfd9.zip | |
pkt_sched: Fix gen_estimator locks
While passing a qdisc root lock to gen_new_estimator() and
gen_replace_estimator() dev could be deactivated or even before
grafting proper root qdisc as qdisc_sleeping (e.g. qdisc_create), so
using qdisc_root_lock() is not enough. This patch adds
qdisc_root_sleeping_lock() for this, plus additional checks, where
necessary.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_hfsc.c')
| -rw-r--r-- | net/sched/sch_hfsc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c index c2b8d9cce3d2..c1e77da8cd09 100644 --- a/net/sched/sch_hfsc.c +++ b/net/sched/sch_hfsc.c @@ -1045,7 +1045,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 parentid, if (tca[TCA_RATE]) gen_replace_estimator(&cl->bstats, &cl->rate_est, - qdisc_root_lock(sch), + qdisc_root_sleeping_lock(sch), tca[TCA_RATE]); return 0; } @@ -1104,7 +1104,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 parentid, if (tca[TCA_RATE]) gen_new_estimator(&cl->bstats, &cl->rate_est, - qdisc_root_lock(sch), tca[TCA_RATE]); + qdisc_root_sleeping_lock(sch), tca[TCA_RATE]); *arg = (unsigned long)cl; return 0; } |