diff options
author | Eric Dumazet <edumazet@google.com> | 2024-01-11 20:49:14 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-01-13 03:14:21 +0100 |
commit | c1665273bdc7c201766c65e561c06711f2e050dc (patch) | |
tree | 9463afde128bccc59ec863f1fa942c326271d62b /net/sched/sch_mqprio_lib.h | |
parent | mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOIN (diff) | |
download | linux-c1665273bdc7c201766c65e561c06711f2e050dc.tar.xz linux-c1665273bdc7c201766c65e561c06711f2e050dc.zip |
mptcp: strict validation before using mp_opt->hmac
mp_opt->hmac contains uninitialized data unless OPTION_MPTCP_MPJ_ACK
was set in mptcp_parse_option().
We must refine the condition before we call subflow_hmac_valid().
Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>
Cc: Peter Krystad <peter.krystad@linux.intel.com>
Cc: Matthieu Baerts <matttbe@kernel.org>
Cc: Mat Martineau <martineau@kernel.org>
Cc: Geliang Tang <geliang.tang@linux.dev>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20240111194917.4044654-3-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/sched/sch_mqprio_lib.h')
0 files changed, 0 insertions, 0 deletions