diff options
author | David S. Miller <davem@davemloft.net> | 2012-03-29 11:11:39 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-04-02 00:11:37 +0200 |
commit | 1b34ec43c9b3de44a5420841ab293d1b2035a94c (patch) | |
tree | 8d6cf966c813e0e61001655179b5ef8e5f1b54b3 /net/sched/sch_multiq.c | |
parent | wireless: Stop using NLA_PUT*(). (diff) | |
download | linux-1b34ec43c9b3de44a5420841ab293d1b2035a94c.tar.xz linux-1b34ec43c9b3de44a5420841ab293d1b2035a94c.zip |
pkt_sched: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_multiq.c')
-rw-r--r-- | net/sched/sch_multiq.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c index 49131d7a7446..2a2b096d9a66 100644 --- a/net/sched/sch_multiq.c +++ b/net/sched/sch_multiq.c @@ -284,7 +284,8 @@ static int multiq_dump(struct Qdisc *sch, struct sk_buff *skb) opt.bands = q->bands; opt.max_bands = q->max_bands; - NLA_PUT(skb, TCA_OPTIONS, sizeof(opt), &opt); + if (nla_put(skb, TCA_OPTIONS, sizeof(opt), &opt)) + goto nla_put_failure; return skb->len; |