diff options
| author | WANG Cong <xiyou.wangcong@gmail.com> | 2016-02-25 23:55:01 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-02-29 23:02:33 +0100 |
| commit | 2ccccf5fb43ff62b2b96cc58d95fc0b3596516e4 (patch) | |
| tree | d73ec90b0c0cfd1191ef35a4aa0eaea78af1f100 /net/sched/sch_pie.c | |
| parent | net_sched: introduce qdisc_replace() helper (diff) | |
| download | linux-2ccccf5fb43ff62b2b96cc58d95fc0b3596516e4.tar.xz linux-2ccccf5fb43ff62b2b96cc58d95fc0b3596516e4.zip | |
net_sched: update hierarchical backlog too
When the bottom qdisc decides to, for example, drop some packet,
it calls qdisc_tree_decrease_qlen() to update the queue length
for all its ancestors, we need to update the backlog too to
keep the stats on root qdisc accurate.
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_pie.c')
| -rw-r--r-- | net/sched/sch_pie.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index b783a446d884..71ae3b9629f9 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -183,7 +183,7 @@ static int pie_change(struct Qdisc *sch, struct nlattr *opt) { struct pie_sched_data *q = qdisc_priv(sch); struct nlattr *tb[TCA_PIE_MAX + 1]; - unsigned int qlen; + unsigned int qlen, dropped = 0; int err; if (!opt) @@ -232,10 +232,11 @@ static int pie_change(struct Qdisc *sch, struct nlattr *opt) while (sch->q.qlen > sch->limit) { struct sk_buff *skb = __skb_dequeue(&sch->q); + dropped += qdisc_pkt_len(skb); qdisc_qstats_backlog_dec(sch, skb); qdisc_drop(skb, sch); } - qdisc_tree_decrease_qlen(sch, qlen - sch->q.qlen); + qdisc_tree_reduce_backlog(sch, qlen - sch->q.qlen, dropped); sch_tree_unlock(sch); return 0; |