summaryrefslogtreecommitdiffstats
path: root/net/sched
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@linux-foundation.org>2007-03-22 20:15:45 +0100
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-26 07:27:20 +0200
commita362e0a7890c735a3ef63aab12d71ecfc6e6f4a5 (patch)
treea92d9d1fc25bc03f0c3d465e40519ea63ce2878f /net/sched
parent[TCP]: cubic optimization (diff)
downloadlinux-a362e0a7890c735a3ef63aab12d71ecfc6e6f4a5.tar.xz
linux-a362e0a7890c735a3ef63aab12d71ecfc6e6f4a5.zip
[NETEM]: report reorder percent correctly.
If you setup netem to just delay packets; "tc qdisc ls" will report the reordering as 100%. Well it's a lie, reorder isn't used unless gap is set, so just set value to 0 so the output of utility is correct. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
-rw-r--r--net/sched/sch_netem.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index 4818da5a7e6c..791c615e3aad 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -429,7 +429,8 @@ static int netem_change(struct Qdisc *sch, struct rtattr *opt)
/* for compatiablity with earlier versions.
* if gap is set, need to assume 100% probablity
*/
- q->reorder = ~0;
+ if (q->gap)
+ q->reorder = ~0;
/* Handle nested options after initial queue options.
* Should have put all options in nested format but too late now.