diff options
| author | Jiri Pirko <jiri@resnulli.us> | 2014-12-02 18:00:34 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-12-09 02:53:40 +0100 |
| commit | 6a659cd0616299e3444db701820b5a35ae054e0e (patch) | |
| tree | 34129393ad452a498f2ed5d199a116a0a6a104c7 /net/sched | |
| parent | net_sched: cls_bpf: remove faulty use of list_for_each_entry_rcu (diff) | |
| download | linux-6a659cd0616299e3444db701820b5a35ae054e0e.tar.xz linux-6a659cd0616299e3444db701820b5a35ae054e0e.zip | |
net_sched: cls_flow: remove faulty use of list_for_each_entry_rcu
rcu variant is not correct here. The code is called by updater (rtnl
lock is held), not by reader (no rcu_read_lock is held).
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/cls_flow.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c index 4ac515f2a6ce..a6057394a207 100644 --- a/net/sched/cls_flow.c +++ b/net/sched/cls_flow.c @@ -578,7 +578,7 @@ static unsigned long flow_get(struct tcf_proto *tp, u32 handle) struct flow_head *head = rtnl_dereference(tp->root); struct flow_filter *f; - list_for_each_entry_rcu(f, &head->filters, list) + list_for_each_entry(f, &head->filters, list) if (f->handle == handle) return (unsigned long)f; return 0; @@ -654,7 +654,7 @@ static void flow_walk(struct tcf_proto *tp, struct tcf_walker *arg) struct flow_head *head = rtnl_dereference(tp->root); struct flow_filter *f; - list_for_each_entry_rcu(f, &head->filters, list) { + list_for_each_entry(f, &head->filters, list) { if (arg->count < arg->skip) goto skip; if (arg->fn(tp, (unsigned long)f, arg) < 0) { |