diff options
| author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2010-09-15 16:00:26 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-18 01:47:56 +0200 |
| commit | 4bdab43323b459900578b200a4b8cf9713ac8fab (patch) | |
| tree | 7a732994407ebb88698845ee36dbf98c062af49e /net/sctp/output.c | |
| parent | net/llc: storing negative error codes in unsigned short (diff) | |
| download | linux-4bdab43323b459900578b200a4b8cf9713ac8fab.tar.xz linux-4bdab43323b459900578b200a4b8cf9713ac8fab.zip | |
sctp: Do not reset the packet during sctp_packet_config().
sctp_packet_config() is called when getting the packet ready
for appending of chunks. The function should not touch the
current state, since it's possible to ping-pong between two
transports when sending, and that can result packet corruption
followed by skb overlfow crash.
Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/output.c')
| -rw-r--r-- | net/sctp/output.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sctp/output.c b/net/sctp/output.c index a646681f5acd..bcc4590ccaf2 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c @@ -92,7 +92,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet, SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__, packet, vtag); - sctp_packet_reset(packet); packet->vtag = vtag; if (ecn_capable && sctp_packet_empty(packet)) { |