diff options
author | Xin Long <lucien.xin@gmail.com> | 2016-01-21 18:49:09 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-01-29 00:59:32 +0100 |
commit | 47faa1e4c50ec26e6e75dcd1ce53f064bd45f729 (patch) | |
tree | efc573a557079fb75d1cf2b1c16d187526884a64 /net/sctp/proc.c | |
parent | sctp: hold transport before we access t->asoc in sctp proc (diff) | |
download | linux-47faa1e4c50ec26e6e75dcd1ce53f064bd45f729.tar.xz linux-47faa1e4c50ec26e6e75dcd1ce53f064bd45f729.zip |
sctp: remove the dead field of sctp_transport
After we use refcnt to check if transport is alive, the dead can be
removed from sctp_transport.
The traversal of transport_addr_list in procfs dump is using
list_for_each_entry_rcu, no need to check if it has been freed.
sctp_generate_t3_rtx_event and sctp_generate_heartbeat_event is
protected by sock lock, it's not necessary to check dead, either.
also, the timers are cancelled when sctp_transport_free() is
called, that it doesn't wait for refcnt to reach 0 to cancel them.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/proc.c')
-rw-r--r-- | net/sctp/proc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sctp/proc.c b/net/sctp/proc.c index c74a810150aa..ded7d931a6a5 100644 --- a/net/sctp/proc.c +++ b/net/sctp/proc.c @@ -165,8 +165,6 @@ static void sctp_seq_dump_remote_addrs(struct seq_file *seq, struct sctp_associa list_for_each_entry_rcu(transport, &assoc->peer.transport_addr_list, transports) { addr = &transport->ipaddr; - if (transport->dead) - continue; af = sctp_get_af_specific(addr->sa.sa_family); if (af->cmp_addr(addr, primary)) { @@ -499,8 +497,6 @@ static int sctp_remaddr_seq_show(struct seq_file *seq, void *v) list_for_each_entry_rcu(tsp, &assoc->peer.transport_addr_list, transports) { - if (tsp->dead) - continue; /* * The remote address (ADDR) */ |