diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-04-03 05:02:28 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-04-07 23:04:17 +0200 |
commit | 524fba6c14d2892bfa27c01577d544d6380291ba (patch) | |
tree | 058453c4d299208117ab8043b920b2a08889cb98 /net/sctp | |
parent | 802: fix a possible race condition (diff) | |
download | linux-524fba6c14d2892bfa27c01577d544d6380291ba.tar.xz linux-524fba6c14d2892bfa27c01577d544d6380291ba.zip |
sctp: fix error return code in __sctp_connect()
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r-- | net/sctp/socket.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index dd21ae3013d8..f631c5ff4dbf 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -1119,9 +1119,10 @@ static int __sctp_connect(struct sock* sk, /* Make sure the destination port is correctly set * in all addresses. */ - if (asoc && asoc->peer.port && asoc->peer.port != port) + if (asoc && asoc->peer.port && asoc->peer.port != port) { + err = -EINVAL; goto out_free; - + } /* Check if there already is a matching association on the * endpoint (other than the one created here). |