diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-15 19:17:45 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-18 13:21:54 +0200 |
| commit | f2f316e287e6c2e3a1c5bab8d9b77ee03daa0463 (patch) | |
| tree | 409c93d609b8093922db66f191223fd3d408d070 /net/smc | |
| parent | igmp: Fix data-races around sysctl_igmp_qrv. (diff) | |
| download | linux-f2f316e287e6c2e3a1c5bab8d9b77ee03daa0463.tar.xz linux-f2f316e287e6c2e3a1c5bab8d9b77ee03daa0463.zip | |
tcp: Fix data-races around keepalive sysctl knobs.
While reading sysctl_tcp_keepalive_(time|probes|intvl), they can be changed
concurrently. Thus, we need to add READ_ONCE() to their readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc')
| -rw-r--r-- | net/smc/smc_llc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c index c4d057b2941d..0bde36b56472 100644 --- a/net/smc/smc_llc.c +++ b/net/smc/smc_llc.c @@ -2122,7 +2122,7 @@ void smc_llc_lgr_init(struct smc_link_group *lgr, struct smc_sock *smc) init_waitqueue_head(&lgr->llc_flow_waiter); init_waitqueue_head(&lgr->llc_msg_waiter); mutex_init(&lgr->llc_conf_mutex); - lgr->llc_testlink_time = net->ipv4.sysctl_tcp_keepalive_time; + lgr->llc_testlink_time = READ_ONCE(net->ipv4.sysctl_tcp_keepalive_time); } /* called after lgr was removed from lgr_list */ |