diff options
| author | David S. Miller <davem@davemloft.net> | 2020-08-27 01:16:39 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-27 01:16:39 +0200 |
| commit | 5875568aa187c0330fdd81159d0d72f855886099 (patch) | |
| tree | 212b4bc9439e21c34da2ad7984be27c7be44a7bd /net/socket.c | |
| parent | ipv4: Silence suspicious RCU usage warning (diff) | |
| parent | bnxt: don't enable NAPI until rings are ready (diff) | |
| download | linux-5875568aa187c0330fdd81159d0d72f855886099.tar.xz linux-5875568aa187c0330fdd81159d0d72f855886099.zip | |
Merge branch 'net-fix-netpoll-crash-with-bnxt'
Jakub Kicinski says:
====================
net: fix netpoll crash with bnxt
Rob run into crashes when using XDP on bnxt. Upon investigation
it turns out that during driver reconfig irq core produces
a warning message when IRQs are requested. This triggers netpoll,
which in turn accesses uninitialized driver state. Same crash can
also be triggered on this platform by changing the number of rings.
Looks like we have two missing pieces here, netif_napi_add() has
to make sure we start out with netpoll blocked. The driver also
has to be more careful about when napi gets enabled.
Tested XDP and channel count changes, the warning message no longer
causes a crash. Not sure if the memory barriers added in patch 1
are necessary, but it seems we should have them.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/socket.c')
0 files changed, 0 insertions, 0 deletions