diff options
| author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-06-11 00:30:11 +0200 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-07-09 18:08:43 +0200 |
| commit | b390c2b55c830eb3b64633fa8d8b8837e073e458 (patch) | |
| tree | e18f0041626a88447d34809f35041cd4b4425610 /net/sunrpc/clnt.c | |
| parent | SUNRPC: Ensure we exit early in case of an encode error (diff) | |
| download | linux-b390c2b55c830eb3b64633fa8d8b8837e073e458.tar.xz linux-b390c2b55c830eb3b64633fa8d8b8837e073e458.zip | |
SUNRPC: An ENOMEM error from call_encode is always fatal
The special 'ENOMEM' case that was previously flagged as non-fatal is
bogus: auth_gss always returns EAGAIN for non-fatal errors, and may in fact
return ENOMEM in the special case where xdr_buf_read_netobj runs out of
preallocated buffer space (invariably a _fatal_ error, since there is no
provision for preallocating larger buffers).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/clnt.c')
| -rw-r--r-- | net/sunrpc/clnt.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 9503b4c177d2..1af4f161cda8 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -888,10 +888,6 @@ call_encode(struct rpc_task *task) task->tk_status = rpcauth_wrap_req(task, encode, req, p, task->tk_msg.rpc_argp); - if (task->tk_status == -ENOMEM) { - /* XXX: Is this sane? */ - task->tk_status = -EAGAIN; - } } /* |