diff options
| author | Pavel Emelyanov <xemul@parallels.com> | 2010-10-06 11:45:56 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2010-10-19 16:48:16 +0200 |
| commit | c636b572e00e38855dc7a56a0fa438dd835f39de (patch) | |
| tree | cd0ce34e01030e61cc0571234b21e0af71e714ff /net/sunrpc/rpcb_clnt.c | |
| parent | sunrpc: Remove useless if (task == NULL) from xprt_reserve_xprt (diff) | |
| download | linux-c636b572e00e38855dc7a56a0fa438dd835f39de.tar.xz linux-c636b572e00e38855dc7a56a0fa438dd835f39de.zip | |
sunrpc: Don't return NULL from rpcb_create
> The reason for this is in the future, we may want to support additional
> address family types. We should, therefore, ensure that every piece of
> code that is sensitive to address families fail in some orderly manner
> to let developers know where a change is needed.
Makes sense. I was under impression, that AF-s other than INET are not
cared about at all :(
Here's a fixed version of the patch.
Log:
Its callers check for ERR_PTR.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc/rpcb_clnt.c')
| -rw-r--r-- | net/sunrpc/rpcb_clnt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index 83af38df3267..1ef2d417af4e 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c @@ -249,7 +249,7 @@ static struct rpc_clnt *rpcb_create(char *hostname, struct sockaddr *srvaddr, ((struct sockaddr_in6 *)srvaddr)->sin6_port = htons(RPCBIND_PORT); break; default: - return NULL; + return ERR_PTR(-EAFNOSUPPORT); } return rpc_create(&args); |