diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2014-10-01 17:36:31 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2014-10-23 20:05:11 +0200 |
| commit | 280caac078d3db075247915f6d2f72315232ed16 (patch) | |
| tree | 0240231b23e40ade309e9345a911118ef8061454 /net/sunrpc/xdr.c | |
| parent | RPC: remove unneeded checks from xdr_truncate_encode() (diff) | |
| download | linux-280caac078d3db075247915f6d2f72315232ed16.tar.xz linux-280caac078d3db075247915f6d2f72315232ed16.zip | |
rpc: change comments to assertions
Reported-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc/xdr.c')
| -rw-r--r-- | net/sunrpc/xdr.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index bcece520c4db..1cb61242e55e 100644 --- a/net/sunrpc/xdr.c +++ b/net/sunrpc/xdr.c @@ -619,7 +619,8 @@ void xdr_truncate_encode(struct xdr_stream *xdr, size_t len) buf->len -= fraglen; if (tail->iov_len) { xdr->p = tail->iov_base + tail->iov_len; - /* xdr->end, xdr->iov should be set already */ + WARN_ON_ONCE(!xdr->end); + WARN_ON_ONCE(!xdr->iov); return; } WARN_ON_ONCE(fraglen); @@ -635,7 +636,7 @@ void xdr_truncate_encode(struct xdr_stream *xdr, size_t len) xdr->p = page_address(*xdr->page_ptr); xdr->end = (void *)xdr->p + PAGE_SIZE; xdr->p = (void *)xdr->p + (new % PAGE_SIZE); - /* xdr->iov should already be NULL */ + WARN_ON_ONCE(xdr->iov); return; } if (fraglen) { |