summaryrefslogtreecommitdiffstats
path: root/net/sunrpc
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2012-07-02 11:15:37 +0200
committerDavid S. Miller <davem@davemloft.net>2012-07-05 10:02:43 +0200
commit60d354ebebd9d0f760cb6c3b9f53a7ade0f8cd0e (patch)
treed9bbbd688e46c339a472683909da65f2efaff564 /net/sunrpc
parentipv4: Don't report neigh uptodate state in rtcache procfs. (diff)
downloadlinux-60d354ebebd9d0f760cb6c3b9f53a7ade0f8cd0e.tar.xz
linux-60d354ebebd9d0f760cb6c3b9f53a7ade0f8cd0e.zip
sunrpc: Don't do a dst_confirm() on an input routes.
xs_udp_data_ready() is operating on received packets, and tries to do a dst_confirm() on the dst attached to the SKB. This isn't right, dst confirmation is for output routes, not input rights. It's for resetting the timers on the nexthop neighbour entry for the route, indicating that we've got good evidence that we've successfully reached it. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sunrpc')
-rw-r--r--net/sunrpc/xprtsock.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 890b03f8d877..62d0dac8f780 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -1014,9 +1014,6 @@ static void xs_udp_data_ready(struct sock *sk, int len)
UDPX_INC_STATS_BH(sk, UDP_MIB_INDATAGRAMS);
- /* Something worked... */
- dst_confirm(skb_dst(skb));
-
xprt_adjust_cwnd(task, copied);
xprt_complete_rqst(task, copied);