summaryrefslogtreecommitdiffstats
path: root/net/sunrpc
diff options
context:
space:
mode:
authorwangweidong <wangweidong1@huawei.com>2013-10-15 05:44:30 +0200
committerTrond Myklebust <Trond.Myklebust@netapp.com>2013-10-28 23:16:56 +0100
commit8313164c36473193c8034de643dc32f35a22bf59 (patch)
treec900e38098f5985b64056dad222cc6f1bc80c333 /net/sunrpc
parentnfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' (diff)
downloadlinux-8313164c36473193c8034de643dc32f35a22bf59.tar.xz
linux-8313164c36473193c8034de643dc32f35a22bf59.zip
SUNRPC: remove an unnecessary if statement
If req allocated failed just goto out_free, no need to check the 'i < num_prealloc'. There is just code simplification, no functional changes. Signed-off-by: Wang Weidong <wangweidong1@huawei.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc')
-rw-r--r--net/sunrpc/xprt.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index 4953550537e0..04199bc8416f 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -1104,11 +1104,9 @@ struct rpc_xprt *xprt_alloc(struct net *net, size_t size,
for (i = 0; i < num_prealloc; i++) {
req = kzalloc(sizeof(struct rpc_rqst), GFP_KERNEL);
if (!req)
- break;
+ goto out_free;
list_add(&req->rq_list, &xprt->free);
}
- if (i < num_prealloc)
- goto out_free;
if (max_alloc > num_prealloc)
xprt->max_reqs = max_alloc;
else