diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2013-10-08 21:53:07 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2013-10-08 21:56:23 +0200 |
| commit | 3be34555fa294483202483c4b171a8d335447187 (patch) | |
| tree | cdcf8e2787d05c7fe4acfc42400e7242dbc9bc4e /net/sunrpc | |
| parent | svcrpc: fix gss-proxy NULL dereference in some error cases (diff) | |
| download | linux-3be34555fa294483202483c4b171a8d335447187.tar.xz linux-3be34555fa294483202483c4b171a8d335447187.zip | |
svcrpc: fix error-handling on badd gssproxy downcall
For every other problem here we bail out with an error, but here for
some reason we're setting a negative cache entry (with, note, an
undefined expiry).
It seems simplest just to bail out in the same way as we do in other
cases.
Cc: Simo Sorce <simo@redhat.com>
Reported-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc')
| -rw-r--r-- | net/sunrpc/auth_gss/svcauth_gss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 09fb638bcaa4..008cdade5aae 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -1167,8 +1167,8 @@ static int gss_proxy_save_rsc(struct cache_detail *cd, if (!ud->found_creds) { /* userspace seem buggy, we should always get at least a * mapping to nobody */ - dprintk("RPC: No creds found, marking Negative!\n"); - set_bit(CACHE_NEGATIVE, &rsci.h.flags); + dprintk("RPC: No creds found!\n"); + goto out; } else { /* steal creds */ |