diff options
| author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-07-04 23:50:36 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-07-07 23:11:44 +0200 |
| commit | 13aecb17acabc2a92187d08f7ca93bb8aad62c6f (patch) | |
| tree | c2af474db0ca07e784e760348511260f93d66b1d /net/tls | |
| parent | ipv4: Fix NULL pointer dereference in ipv4_neigh_lookup() (diff) | |
| download | linux-13aecb17acabc2a92187d08f7ca93bb8aad62c6f.tar.xz linux-13aecb17acabc2a92187d08f7ca93bb8aad62c6f.zip | |
net/tls: fix poll ignoring partially copied records
David reports that RPC applications which use epoll() occasionally
get stuck, and that TLS ULP causes the kernel to not wake applications,
even though read() will return data.
This is indeed true. The ctx->rx_list which holds partially copied
records is not consulted when deciding whether socket is readable.
Note that SO_RCVLOWAT with epoll() is and has always been broken for
kernel TLS. We'd need to parse all records from the TCP layer, instead
of just the first one.
Fixes: 692d7b5d1f91 ("tls: Fix recvmsg() to be able to peek across multiple records")
Reported-by: David Beckett <david.beckett@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls')
| -rw-r--r-- | net/tls/tls_sw.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 455a782c7658..e2385183526e 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -1958,7 +1958,8 @@ bool tls_sw_stream_read(const struct sock *sk) ingress_empty = list_empty(&psock->ingress_msg); rcu_read_unlock(); - return !ingress_empty || ctx->recv_pkt; + return !ingress_empty || ctx->recv_pkt || + !skb_queue_empty(&ctx->rx_list); } static int tls_read_size(struct strparser *strp, struct sk_buff *skb) |