diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2012-06-05 19:56:06 +0200 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2012-06-05 20:27:29 +0200 |
| commit | f69a23b795d6ee3673583146ed7efcbaaa5add18 (patch) | |
| tree | fdf77d4e1d59490a1f5c1584cb853a3fe32c8255 /net/wireless/util.c | |
| parent | iwlwifi: disable WoWLAN if !CONFIG_PM_SLEEP (diff) | |
| download | linux-f69a23b795d6ee3673583146ed7efcbaaa5add18.tar.xz linux-f69a23b795d6ee3673583146ed7efcbaaa5add18.zip | |
iwlwifi: fix double free/complete in firmware loading
Linus reported that due to mac80211 failing to register
the device (due to WoWLAN) his machine crashed etc. as
we double-freed the vmalloc() firmware area. His patch
to fix it was very similar to this one but I noticed
that there's another bug in the area: we complete the
completion before starting, so since we're running in
a work struct context stop() could be called while in
the middle of start() which will almost certainly lead
to issues.
Make a modification similar to his to avoid the double-
free but also move the completion to another spot so it
is only done after start() either finished or failed so
that stop() can have a consistent state.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/wireless/util.c')
0 files changed, 0 insertions, 0 deletions