diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2016-08-11 14:59:53 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2016-08-11 20:00:37 +0200 |
| commit | ff9a71afc948f609c4eaba47cd6788926e7cc105 (patch) | |
| tree | 16ea14e36fcb0bb4058906241ae72140fc1fb3d6 /net/wireless | |
| parent | mac80211: call get_expected_throughput only after adding station (diff) | |
| download | linux-ff9a71afc948f609c4eaba47cd6788926e7cc105.tar.xz linux-ff9a71afc948f609c4eaba47cd6788926e7cc105.zip | |
nl80211: explicitly check enum nl80211_mesh_power_mode
Different gcc versions appear to be treating enum with different
signedness, causing warnings with the out parameter one way or
the other.
Just use the correct type to avoid all that.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
| -rw-r--r-- | net/wireless/nl80211.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index d36c40a4d832..499785778983 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5353,6 +5353,18 @@ static int nl80211_check_s32(const struct nlattr *nla, s32 min, s32 max, s32 *ou return 0; } +static int nl80211_check_power_mode(const struct nlattr *nla, + enum nl80211_mesh_power_mode min, + enum nl80211_mesh_power_mode max, + enum nl80211_mesh_power_mode *out) +{ + u32 val = nla_get_u32(nla); + if (val < min || val > max) + return -EINVAL; + *out = val; + return 0; +} + static int nl80211_parse_mesh_config(struct genl_info *info, struct mesh_config *cfg, u32 *mask_out) @@ -5497,7 +5509,7 @@ do { \ NL80211_MESH_POWER_ACTIVE, NL80211_MESH_POWER_MAX, mask, NL80211_MESHCONF_POWER_MODE, - nl80211_check_u32); + nl80211_check_power_mode); FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshAwakeWindowDuration, 0, 65535, mask, NL80211_MESHCONF_AWAKE_WINDOW, nl80211_check_u16); |