diff options
| author | Rameshkumar Sundaram <quic_ramess@quicinc.com> | 2022-04-11 11:07:51 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2022-04-11 11:55:36 +0200 |
| commit | a5199b5626cd6913cf8776a835bc63d40e0686ad (patch) | |
| tree | 4b34baeeab52e73a8d54370be8c091d6a6aee703 /net/wireless | |
| parent | nl80211: correctly check NL80211_ATTR_REG_ALPHA2 size (diff) | |
| download | linux-a5199b5626cd6913cf8776a835bc63d40e0686ad.tar.xz linux-a5199b5626cd6913cf8776a835bc63d40e0686ad.zip | |
cfg80211: hold bss_lock while updating nontrans_list
Synchronize additions to nontrans_list of transmitting BSS with
bss_lock to avoid races. Also when cfg80211_add_nontrans_list() fails
__cfg80211_unlink_bss() needs bss_lock to be held (has lockdep assert
on bss_lock). So protect the whole block with bss_lock to avoid
races and warnings. Found during code review.
Fixes: 0b8fb8235be8 ("cfg80211: Parsing of Multiple BSSID information in scanning")
Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
Link: https://lore.kernel.org/r/1649668071-9370-1-git-send-email-quic_ramess@quicinc.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
| -rw-r--r-- | net/wireless/scan.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/wireless/scan.c b/net/wireless/scan.c index b2fdac96bab0..4a6d86432910 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -2018,11 +2018,13 @@ cfg80211_inform_single_bss_data(struct wiphy *wiphy, /* this is a nontransmitting bss, we need to add it to * transmitting bss' list if it is not there */ + spin_lock_bh(&rdev->bss_lock); if (cfg80211_add_nontrans_list(non_tx_data->tx_bss, &res->pub)) { if (__cfg80211_unlink_bss(rdev, res)) rdev->bss_generation++; } + spin_unlock_bh(&rdev->bss_lock); } trace_cfg80211_return_bss(&res->pub); |