diff options
author | Eric Dumazet <edumazet@google.com> | 2019-11-05 23:11:52 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-11-07 01:14:48 +0100 |
commit | 7976a11b30929871a4c84c3c406d7681a3dbcc10 (patch) | |
tree | bdbef4ca196215ba83037b47bbcc5820e614e3e9 /net/x25/af_x25.c | |
parent | net: avoid potential false sharing in neighbor related code (diff) | |
download | linux-7976a11b30929871a4c84c3c406d7681a3dbcc10.tar.xz linux-7976a11b30929871a4c84c3c406d7681a3dbcc10.zip |
net: use helpers to change sk_ack_backlog
Writers are holding a lock, but many readers do not.
Following patch will add appropriate barriers in
sk_acceptq_removed() and sk_acceptq_added().
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/x25/af_x25.c')
-rw-r--r-- | net/x25/af_x25.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index 6aee9f5e8e71..c34f7d077604 100644 --- a/net/x25/af_x25.c +++ b/net/x25/af_x25.c @@ -891,7 +891,7 @@ static int x25_accept(struct socket *sock, struct socket *newsock, int flags, /* Now attach up the new socket */ skb->sk = NULL; kfree_skb(skb); - sk->sk_ack_backlog--; + sk_acceptq_removed(sk); newsock->state = SS_CONNECTED; rc = 0; out2: @@ -1062,7 +1062,7 @@ int x25_rx_call_request(struct sk_buff *skb, struct x25_neigh *nb, skb_copy_from_linear_data(skb, makex25->calluserdata.cuddata, skb->len); makex25->calluserdata.cudlength = skb->len; - sk->sk_ack_backlog++; + sk_acceptq_added(sk); x25_insert_socket(make); |