summaryrefslogtreecommitdiffstats
path: root/net/x25
diff options
context:
space:
mode:
authorchenqiwu <chenqiwu@xiaomi.com>2020-02-14 10:18:26 +0100
committerDavid S. Miller <davem@davemloft.net>2020-02-17 03:59:42 +0100
commit1e5946f5f7fe9267c71097a83615a6e5eb0f4cfd (patch)
tree8913958128adf1bfc1ad88f31c2cf0a2dd0ab932 /net/x25
parentlib: objagg: Replace zero-length arrays with flexible-array member (diff)
downloadlinux-1e5946f5f7fe9267c71097a83615a6e5eb0f4cfd.tar.xz
linux-1e5946f5f7fe9267c71097a83615a6e5eb0f4cfd.zip
net: x25: convert to list_for_each_entry_safe()
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: chenqiwu <chenqiwu@xiaomi.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/x25')
-rw-r--r--net/x25/x25_forward.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/net/x25/x25_forward.c b/net/x25/x25_forward.c
index c82999941d3f..d48ad6d29197 100644
--- a/net/x25/x25_forward.c
+++ b/net/x25/x25_forward.c
@@ -131,13 +131,11 @@ out:
void x25_clear_forward_by_lci(unsigned int lci)
{
- struct x25_forward *fwd;
- struct list_head *entry, *tmp;
+ struct x25_forward *fwd, *tmp;
write_lock_bh(&x25_forward_list_lock);
- list_for_each_safe(entry, tmp, &x25_forward_list) {
- fwd = list_entry(entry, struct x25_forward, node);
+ list_for_each_entry_safe(fwd, tmp, &x25_forward_list, node) {
if (fwd->lci == lci) {
list_del(&fwd->node);
kfree(fwd);
@@ -149,13 +147,11 @@ void x25_clear_forward_by_lci(unsigned int lci)
void x25_clear_forward_by_dev(struct net_device *dev)
{
- struct x25_forward *fwd;
- struct list_head *entry, *tmp;
+ struct x25_forward *fwd, *tmp;
write_lock_bh(&x25_forward_list_lock);
- list_for_each_safe(entry, tmp, &x25_forward_list) {
- fwd = list_entry(entry, struct x25_forward, node);
+ list_for_each_entry_safe(fwd, tmp, &x25_forward_list, node) {
if ((fwd->dev1 == dev) || (fwd->dev2 == dev)){
list_del(&fwd->node);
kfree(fwd);