summaryrefslogtreecommitdiffstats
path: root/net/x25
diff options
context:
space:
mode:
authorXie He <xie.he.0141@gmail.com>2020-11-12 11:35:06 +0100
committerJakub Kicinski <kuba@kernel.org>2020-11-13 03:01:40 +0100
commit4ee18c179e5e815fa5575e0d2db0c05795a804ee (patch)
tree4cbaefadd16d1c1c2a475ddab9d51611dd74c94a /net/x25
parentnet: ethernet: mtk-star-emac: fix error return code in mtk_star_enable() (diff)
downloadlinux-4ee18c179e5e815fa5575e0d2db0c05795a804ee.tar.xz
linux-4ee18c179e5e815fa5575e0d2db0c05795a804ee.zip
net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request
The x25_disconnect function in x25_subr.c would decrease the refcount of "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL. However, the x25_rx_call_request function in af_x25.c, which is called when we receive a connection request, does not increase the refcount when it assigns the pointer. Fix this issue by increasing the refcount of "struct x25_neigh" in x25_rx_call_request. This patch fixes frequent kernel crashes when using AF_X25 sockets. Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect") Cc: Martin Schiller <ms@dev.tdt.de> Signed-off-by: Xie He <xie.he.0141@gmail.com> Link: https://lore.kernel.org/r/20201112103506.5875-1-xie.he.0141@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/x25')
-rw-r--r--net/x25/af_x25.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 046d3fee66a9..a10487e7574c 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -1050,6 +1050,7 @@ int x25_rx_call_request(struct sk_buff *skb, struct x25_neigh *nb,
makex25->lci = lci;
makex25->dest_addr = dest_addr;
makex25->source_addr = source_addr;
+ x25_neigh_hold(nb);
makex25->neighbour = nb;
makex25->facilities = facilities;
makex25->dte_facilities= dte_facilities;