summaryrefslogtreecommitdiffstats
path: root/net/xfrm
diff options
context:
space:
mode:
authorNicolas Dichtel <nicolas.dichtel@6wind.com>2020-04-23 11:39:20 +0200
committerSteffen Klassert <steffen.klassert@secunet.com>2020-04-27 08:50:49 +0200
commite62905ae34eaf5fe2cfb254be5e0c097b3b1f798 (patch)
treef9f5f42ed5767a7362cb7549bad56c660c717034 /net/xfrm
parentnet: ipv4: remove redundant assignment to variable rc (diff)
downloadlinux-e62905ae34eaf5fe2cfb254be5e0c097b3b1f798.tar.xz
linux-e62905ae34eaf5fe2cfb254be5e0c097b3b1f798.zip
xfrm interface: don't take extra reference to netdev
I don't see any reason to do this. Maybe needed before commit 56c5ee1a5823 ("xfrm interface: fix memory leak on creation"). Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/xfrm')
-rw-r--r--net/xfrm/xfrm_interface.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 3361e3ac5714..eb9928c0a87c 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -145,7 +145,6 @@ static int xfrmi_create(struct net_device *dev)
if (err < 0)
goto out;
- dev_hold(dev);
xfrmi_link(xfrmn, xi);
return 0;
@@ -175,7 +174,6 @@ static void xfrmi_dev_uninit(struct net_device *dev)
struct xfrmi_net *xfrmn = net_generic(xi->net, xfrmi_net_id);
xfrmi_unlink(xfrmn, xi);
- dev_put(dev);
}
static void xfrmi_scrub_packet(struct sk_buff *skb, bool xnet)