summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2006-03-13 05:33:22 +0100
committerDavid S. Miller <davem@sunset.davemloft.net>2006-03-13 05:39:36 +0100
commitf6e57464df7ba0e91a23b0854adb56852dcd58a7 (patch)
tree9dfee36ee4e5150a3af876b44bca7516554aa5ec /net
parent[NETFILTER]: nfnetlink_queue: fix possible NULL-ptr dereference (diff)
downloadlinux-f6e57464df7ba0e91a23b0854adb56852dcd58a7.tar.xz
linux-f6e57464df7ba0e91a23b0854adb56852dcd58a7.zip
[NET_SCHED]: act_api: fix skb leak in error path
The skb is allocated by the function, so it needs to be freed instead of trimmed on overrun. Coverity #614 Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/sched/act_api.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 792ce59940ec..2ffa11c6e8de 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -707,7 +707,7 @@ static int tcf_add_notify(struct tc_action *a, u32 pid, u32 seq, int event,
rtattr_failure:
nlmsg_failure:
- skb_trim(skb, b - skb->data);
+ kfree_skb(skb);
return -1;
}