diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-07-03 12:53:42 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-07-03 12:53:42 +0200 |
| commit | ab1b20467cd2214ad89a95d007047cd2a6b5bf5d (patch) | |
| tree | d6cb28dab25eada6f2963d23afd284d0b899bab5 /net | |
| parent | tcp: fix a size_t < 0 comparison in tcp_read_sock (diff) | |
| download | linux-ab1b20467cd2214ad89a95d007047cd2a6b5bf5d.tar.xz linux-ab1b20467cd2214ad89a95d007047cd2a6b5bf5d.zip | |
bridge: fix use-after-free in br_cleanup_bridges()
Unregistering a bridge device may cause virtual devices stacked on the
bridge, like vlan or macvlan devices, to be unregistered as well.
br_cleanup_bridges() uses for_each_netdev_safe() to iterate over all
devices during cleanup. This is not enough however, if one of the
additionally unregistered devices is next in the list to the bridge
device, it will get freed as well and the iteration continues on
the freed element.
Restart iteration after each bridge device removal from the beginning to
fix this, similar to what rtnl_link_unregister() does.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bridge/br_if.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c2397f503b0f..f38cc5317b88 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -442,12 +442,16 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) void __exit br_cleanup_bridges(void) { - struct net_device *dev, *nxt; + struct net_device *dev; rtnl_lock(); - for_each_netdev_safe(&init_net, dev, nxt) - if (dev->priv_flags & IFF_EBRIDGE) +restart: + for_each_netdev(&init_net, dev) { + if (dev->priv_flags & IFF_EBRIDGE) { del_br(dev->priv); + goto restart; + } + } rtnl_unlock(); } |