diff options
| author | Mathieu Poirier <mathieu.poirier@linaro.org> | 2014-06-02 03:42:58 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-06-02 10:46:52 +0200 |
| commit | 4c552a64dfc2063ef060cf45788cd4250eea3596 (patch) | |
| tree | 36552dbf4d62f82ca9cb4e78f97fa13d555cfc21 /net | |
| parent | Revert "net/mlx4_en: Use affinity hint" (diff) | |
| download | linux-4c552a64dfc2063ef060cf45788cd4250eea3596.tar.xz linux-4c552a64dfc2063ef060cf45788cd4250eea3596.zip | |
netfilter: nfnetlink_acct: Fix memory leak
Allocation of memory need only to happen once, that is
after the proper checks on the NFACCT_FLAGS have been
done. Otherwise the code can return without freeing
already allocated memory.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nfnetlink_acct.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c index 70e86bbb3637..54af9853e2cd 100644 --- a/net/netfilter/nfnetlink_acct.c +++ b/net/netfilter/nfnetlink_acct.c @@ -83,7 +83,6 @@ nfnl_acct_new(struct sock *nfnl, struct sk_buff *skb, return -EBUSY; } - nfacct = kzalloc(sizeof(struct nf_acct), GFP_KERNEL); if (tb[NFACCT_FLAGS]) { flags = ntohl(nla_get_be32(tb[NFACCT_FLAGS])); if (flags & ~NFACCT_F_QUOTA) |