diff options
| author | Nikolay Aleksandrov <nikolay@cumulusnetworks.com> | 2015-07-13 15:36:19 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-07-16 02:15:01 +0200 |
| commit | 5ebc784625ea68a9570d1f70557e7932988cd1b4 (patch) | |
| tree | 0f2529bbdd644a415d32f95b2058ead34dc54ac0 /net | |
| parent | bridge: multicast: treat igmpv3 report with INCLUDE and no sources as a leave (diff) | |
| download | linux-5ebc784625ea68a9570d1f70557e7932988cd1b4.tar.xz linux-5ebc784625ea68a9570d1f70557e7932988cd1b4.zip | |
bridge: mdb: fix double add notification
Since the mdb add/del code was introduced there have been 2 br_mdb_notify
calls when doing br_mdb_add() resulting in 2 notifications on each add.
Example:
Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
Before patch:
root@debian:~# bridge monitor all
[MDB]dev br0 port eth1 grp 239.0.0.1 permanent
[MDB]dev br0 port eth1 grp 239.0.0.1 permanent
After patch:
root@debian:~# bridge monitor all
[MDB]dev br0 port eth1 grp 239.0.0.1 permanent
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bridge/br_mdb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index c11cf2611db0..1198a3dbad95 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -351,7 +351,6 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port, if (state == MDB_TEMPORARY) mod_timer(&p->timer, now + br->multicast_membership_interval); - br_mdb_notify(br->dev, port, group, RTM_NEWMDB); return 0; } |