summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2012-07-12 06:30:08 +0200
committerDavid S. Miller <davem@davemloft.net>2012-07-12 06:30:08 +0200
commit1f42539d257af671d56d4bdbcf13aef31abff6ef (patch)
treee48de1974ba75f1b31d90f8348ba6a5514dba526 /net
parentipv4: Add redirect support to all protocol icmp error handlers. (diff)
downloadlinux-1f42539d257af671d56d4bdbcf13aef31abff6ef.tar.xz
linux-1f42539d257af671d56d4bdbcf13aef31abff6ef.zip
ipv4: Kill ip_rt_redirect().
No longer needed, as the protocol handlers now all properly propagate the redirect back into the routing code. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/icmp.c1
-rw-r--r--net/ipv4/route.c44
2 files changed, 0 insertions, 45 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index 70a793559bb5..d01aeb4d492e 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -763,7 +763,6 @@ static void icmp_redirect(struct sk_buff *skb)
if (!pskb_may_pull(skb, sizeof(struct iphdr)))
return;
- ip_rt_redirect(skb, icmp_hdr(skb)->un.gateway);
icmp_socket_deliver(skb, icmp_hdr(skb)->un.gateway);
}
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index aabece6b729a..e98207dcd088 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1345,50 +1345,6 @@ reject_redirect:
;
}
-/* called in rcu_read_lock() section */
-void ip_rt_redirect(struct sk_buff *skb, __be32 new_gw)
-{
- const struct iphdr *iph = (const struct iphdr *) skb->data;
- __be32 daddr = iph->daddr;
- __be32 saddr = iph->saddr;
- struct net_device *dev = skb->dev;
- int ikeys[2] = { dev->ifindex, 0 };
- __be32 skeys[2] = { saddr, 0 };
- struct net *net;
- int s, i;
-
- net = dev_net(dev);
- for (s = 0; s < 2; s++) {
- for (i = 0; i < 2; i++) {
- unsigned int hash;
- struct rtable __rcu **rthp;
- struct rtable *rt;
-
- hash = rt_hash(daddr, skeys[s], ikeys[i], rt_genid(net));
-
- rthp = &rt_hash_table[hash].chain;
-
- while ((rt = rcu_dereference(*rthp)) != NULL) {
- rthp = &rt->dst.rt_next;
-
- if (rt->rt_key_dst != daddr ||
- rt->rt_key_src != skeys[s] ||
- rt->rt_oif != ikeys[i] ||
- rt_is_input_route(rt) ||
- rt_is_expired(rt) ||
- !net_eq(dev_net(rt->dst.dev), net) ||
- rt->dst.error ||
- rt->dst.dev != dev)
- continue;
-
- ip_do_redirect(&rt->dst, skb);
- }
- }
- }
- return;
-
-}
-
static struct dst_entry *ipv4_negative_advice(struct dst_entry *dst)
{
struct rtable *rt = (struct rtable *)dst;