diff options
author | Felix Fietkau <nbd@nbd.name> | 2020-11-11 19:33:59 +0100 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2020-11-12 11:25:09 +0100 |
commit | b2911a84396f72149dce310a3b64d8948212c1b3 (patch) | |
tree | bd7f61dc404f5c457c423e8220f1d3575a99e9fc /net | |
parent | mac80211: minstrel: remove deferred sampling code (diff) | |
download | linux-b2911a84396f72149dce310a3b64d8948212c1b3.tar.xz linux-b2911a84396f72149dce310a3b64d8948212c1b3.zip |
mac80211: minstrel: fix tx status processing corner case
Some drivers fill the status rate list without setting the rate index after
the final rate to -1. minstrel_ht already deals with this, but minstrel
doesn't, which causes it to get stuck at the lowest rate on these drivers.
Fix this by checking the count as well.
Cc: stable@vger.kernel.org
Fixes: cccf129f820e ("mac80211: add the 'minstrel' rate control algorithm")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20201111183359.43528-3-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/mac80211/rc80211_minstrel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c index a8a940e97a9a..b13b1da19386 100644 --- a/net/mac80211/rc80211_minstrel.c +++ b/net/mac80211/rc80211_minstrel.c @@ -274,7 +274,7 @@ minstrel_tx_status(void *priv, struct ieee80211_supported_band *sband, success = !!(info->flags & IEEE80211_TX_STAT_ACK); for (i = 0; i < IEEE80211_TX_MAX_RATES; i++) { - if (ar[i].idx < 0) + if (ar[i].idx < 0 || !ar[i].count) break; ndx = rix_to_ndx(mi, ar[i].idx); |