diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2016-08-01 13:13:08 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2016-08-08 11:27:37 +0200 |
| commit | c1eda3c6394f805886b2afa8c7ea5e04305ec698 (patch) | |
| tree | 4ffbd5227f627403d89a2aa67b832d50802462f3 /net | |
| parent | netfilter: nf_tables: s/MFT_REG32_01/NFT_REG32_01 (diff) | |
| download | linux-c1eda3c6394f805886b2afa8c7ea5e04305ec698.tar.xz linux-c1eda3c6394f805886b2afa8c7ea5e04305ec698.zip | |
netfilter: nft_rbtree: ignore inactive matching element with no descendants
If we find a matching element that is inactive with no descendants, we
jump to the found label, then crash because of nul-dereference on the
left branch.
Fix this by checking that the element is active and not an interval end
and skipping the logic that only applies to the tree iteration.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Tested-by: Anders K. Pedersen <akp@akp.dk>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nft_rbtree.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/net/netfilter/nft_rbtree.c b/net/netfilter/nft_rbtree.c index 6473936d05c6..ffe9ae062d23 100644 --- a/net/netfilter/nft_rbtree.c +++ b/net/netfilter/nft_rbtree.c @@ -70,7 +70,6 @@ static bool nft_rbtree_lookup(const struct net *net, const struct nft_set *set, } else if (d > 0) parent = parent->rb_right; else { -found: if (!nft_set_elem_active(&rbe->ext, genmask)) { parent = parent->rb_left; continue; @@ -84,9 +83,12 @@ found: } } - if (set->flags & NFT_SET_INTERVAL && interval != NULL) { - rbe = interval; - goto found; + if (set->flags & NFT_SET_INTERVAL && interval != NULL && + nft_set_elem_active(&interval->ext, genmask) && + !nft_rbtree_interval_end(interval)) { + spin_unlock_bh(&nft_rbtree_lock); + *ext = &interval->ext; + return true; } out: spin_unlock_bh(&nft_rbtree_lock); |