diff options
| author | Sven Eckelmann <sven@narfation.org> | 2016-03-05 16:09:20 +0100 |
|---|---|---|
| committer | Antonio Quartulli <a@unstable.cc> | 2016-05-10 12:28:29 +0200 |
| commit | c9dad805e9f4fd3978f22c970bae49eaa00b46dd (patch) | |
| tree | 6de3a8eaeeafaff0c0f44d380eb96f056bef5e53 /net | |
| parent | batman-adv: Increase hard_iface refcnt for ptype (diff) | |
| download | linux-c9dad805e9f4fd3978f22c970bae49eaa00b46dd.tar.xz linux-c9dad805e9f4fd3978f22c970bae49eaa00b46dd.zip | |
batman-adv: Use kref_get for batadv_tvlv_container_get
batadv_tvlv_container_get requires that tvlv.container_list_lock is held by
the caller. It is therefore not possible that an item in
tvlv.container_list has an reference counter of 0 and is still in the list
The kref_get function instead WARNs (with debug information) when the
reference counter would still be 0. This makes a bug in batman-adv better
visible because kref_get_unless_zero would have ignored this problem.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net')
| -rw-r--r-- | net/batman-adv/main.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index c8d8bc78a518..5f2974bd1227 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -748,9 +748,7 @@ batadv_tvlv_container_get(struct batadv_priv *bat_priv, u8 type, u8 version) if (tvlv_tmp->tvlv_hdr.version != version) continue; - if (!kref_get_unless_zero(&tvlv_tmp->refcount)) - continue; - + kref_get(&tvlv_tmp->refcount); tvlv = tvlv_tmp; break; } |